Repository navigation
feat(cache): let a hit rebuild empty folders the task made - #917
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
October 30, 2026 03:20
d7c8a30 to
78b8ee8
Compare
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
October 30, 2026 04:07
78b8ee8 to
922a074
Compare
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
October 30, 2026 06:31
922a074 to
2166c58
Compare
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
October 30, 2026 07:08
2166c58 to
b81c7bb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b81c7bb. Configure here.
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
November 1, 2026 11:55
b81c7bb to
e038c4c
Compare
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
November 5, 2026 08:54
e038c4c to
548a884
Compare
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
November 5, 2026 09:02
548a884 to
dedf87c
Compare
Three cases for a task whose output folder holds an empty folder it made. In `empty_folder_in_output`, the task makes `out/empty`, writes `out/a.txt` and stats `out`, through `vtt fs`; in `empty_folder_in_output_globs`, the same task has the explicit `output` glob `out/**`, which matches `out/empty`. In `astro_empty_collections`, `astro build` (Astro 6, added to `packages/tools`) on a one-page site makes `.astro/collections` and leaves it empty, next to the `.d.ts` files it writes in `.astro`, and stats both folders. Today a folder holding an empty folder isn't rebuildable, since fspy doesn't record a mkdir as one, so removing it, as on a clean checkout, is a cache miss. On Windows, where a mkdir is recorded as a read, the empty folder is an input too, and vt names whichever removed input its parallel validation finds first, so the synthetic cases redact the miss reason. Astro needs Vite 7, so a scoped `astro>vite` override keeps the global `vite` override from handing it the Vite+ fork. esbuild and sharp, which Astro depends on, get their prebuilt binaries as optional dependencies, so their build scripts are skipped. The Astro case removes `.astro`, `dist`, `node_modules/.astro` and `node_modules/.vite/deps`, not all of `node_modules/.vite`, which holds the task cache too, and recreates nothing, as on a clean checkout. Several inputs are then missing, and vt names whichever its parallel validation finds first, so the next step redacts its miss reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task that makes a folder and leaves it empty, like `astro build` making `.astro/collections`, pinned the folder holding it as an input: fspy didn't record a mkdir as one (on Windows it was a read), so the empty folder wasn't rebuildable, and the archive held only files, so a hit couldn't recreate it. Removing the folder, as on a clean checkout, was a cache miss. fspy now records the path of a mkdir as a mkdir, a new access kind, before the call, so a failed call, like one finding the folder there already, is recorded too: - Unix preload: `mkdir` and `mkdirat`. - Linux seccomp supervisor, for static binaries: `mkdirat`, plus `mkdir` on x86_64. - Windows: `NtCreateFile` with `FILE_DIRECTORY_FILE` and `FILE_CREATE` or `FILE_OPEN_IF`, where `CreateDirectoryW` ends. These opens were recorded as reads; a mkdir isn't one on Unix either. `Rebuildable` takes the mkdirs that are empty folders after the run (`.DS_Store` aside) as rebuildable folders and climbs from them too, so a folder holding only such folders, rebuildable folders and files the task wrote is rebuildable. Each folder is listed once: a mkdir'd folder above a written path is decided while climbing, where an empty one counts as rebuildable, and only the other mkdirs are checked for being empty. A run without inferred reads skips the climb and checks every mkdir, for the archive. The archive gets directory entries for the empty folders, filtered by output exclusions and `ignoreOutput` like files: all of them with automatic output tracking, and otherwise those an `output` glob matches, since the glob walk yields files only. Restoring recreates them. A folder holding anything needs no entry, since what it holds recreates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-empty-folders
branch
from
November 5, 2026 09:17
dedf87c to
5cdc29e
Compare
wan9chi
added a commit
that referenced
this pull request
Nov 5, 2026
## Motivation Follow-ups to the rebuildable-inputs stack (#913–#919, #940, #941), now merged: - The real-world case for files renamed into place (#916) used Vitest's `fsModuleCache`, which renames cache entries rather than outputs. - #919's e2e cases test a listing entry like any other, so they add no coverage of their own. - The stack added eight changelog entries, most of them for what users see as one feature. - Socket flagged Astro 6.4.8, which #917 added for its real-world case: critical advisory GHSA-26w7-cxv4-gfx2 (remote code execution through AVIF image optimization), fixed in Astro 7.2.8. ## Changes - New case `next_build_moved_pages`: Next.js 15's `next build` renders each static page (`index.html`, `404.html`, `500.html`) into `.next/export` and renames it into `.next/server/pages`. After `.next` is removed, the next run is a cache hit that restores the pages. The build log is redacted, since its progress lines, sizes and chunk hashes vary. It replaces `vitest_fs_module_cache`, along with the SHA-1 redaction only that case used. `next`, `react` and `react-dom` join `packages/tools`. - `dist_appears_in_listed_folder` and `oxlint_dist` are removed. - The changelog entries of #913–#918 are combined into one **Added** item for rebuildable inputs; #919 (`dist` in listings) and #941 (input exclusions apply to listings) stay their own short items, and so does #940's fix. - On Windows CI, the e2e harness stages fixtures in `RUNNER_TEMP`, on the checkout's drive: the staged workspaces resolve `node_modules` into the checkout, and Next.js builds its client entry from a path relative to the project, which can't cross drives. - Astro 6.4.8 → 7.3.8, the newest release that still supports the repo's Node 22.19. Astro 7 needs upstream Vite 8, so its scoped override now points at Vite 8.3.2. `astro_empty_collections` passes unchanged; its comment now says Astro 7 stats the project root rather than listing it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test harness, changelog, and dependency catalog changes only; no changes to task caching or file-tracking behavior in this diff. > > **Overview** > Follow-up after the rebuildable-inputs stack lands: **no runtime cache logic changes**—mostly release notes, snapshot tests, and toolchain bumps. > > The **changelog** folds the former #913–#918 narrative into one **Added** “rebuildable inputs” entry and shortens the #919 / #941 **Changed** bullets; #940 stays separate. > > **E2E snapshots** swap coverage: **`next_build_moved_pages`** (Next.js 15 renaming `.next/export` → `.next/server/pages`, cache hit after deleting `.next`) replaces **`vitest_fs_module_cache`**; **`dist_appears_in_listed_folder`** and **`oxlint_dist`** are dropped as redundant with listing behavior elsewhere. Snapshot **redaction** drops SHA-1 normalization (Vitest-only). On **Windows CI**, fixtures stage under **`RUNNER_TEMP`** so Next’s client entry paths stay on the checkout drive. > > **Deps**: catalog adds **Next 15**, **React 19**, bumps **Astro 6 → 7.3.8** (security advisory), and scopes **`astro>vite`** to upstream **Vite 8.3.2**. The Astro empty-collections fixture comment reflects Astro 7 **stat**-ing the project root instead of listing it. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4c8f40c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A task that makes a folder and leaves it empty can't be rebuilt by a hit today;
astro build, for example, makes.astro/collections. fspy records nothing formkdir, and the archive holds only files, so the folder holding the empty one stays pinned and a clean checkout misses.Changes
mkdiras a new access kind,Mkdir, before the call. This covers the Unix preload, the Linux seccomp supervisor and WindowsNtCreateFilecreating a directory; on Windows those calls were recorded as reads.ignoreOutputlike files: all of them with automatic output tracking, otherwise those anoutputglob matches. A restore recreates them.E2E cases:
empty_folder_in_outputandempty_folder_in_output_globs(synthetic; automatic outputs and explicitoutputglobs) andastro_empty_collections(astro buildwith Astro 6.4.8, added topackages/toolswith a scopedviteoverride; true clean checkout).Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code
Note
Medium Risk
Changes core cache fingerprinting, output archiving, and cross-platform fspy semantics; incorrect mkdir or empty-folder handling could cause false cache hits or incomplete restores.
Overview
Cache hits now recreate empty directories the task created (e.g. Astro’s
.astro/collections), instead of leaving them missing and forcing misses when a parent folder was deleted.fspy gains a
Mkdiraccess kind: Unixmkdir/mkdirat(preload + seccomp) and Windows directoryNtCreateFile(FILE_CREATE/FILE_OPEN_IF+FILE_DIRECTORY_FILE) are recorded as mkdir, not as reads. Failed mkdirs are still logged, matching rename-target behavior.Rebuild / fingerprint / archive pipeline: empty task-made folders are treated as rebuildable (skipped in input fingerprints like other output-only trees), collected into
empty_folders, written into the output tar.zst as directory entries, and restored on replay. With automatic outputs, all such folders are archived; with explicitoutputglobs, only paths the globs match. Parent folders that hold only rebuildable outputs can be absent on a clean checkout without invalidating the fingerprint.Adds e2e snapshots for a synthetic empty-folder task (with and without globs) and
astro build(Astro 6 inpackages/tools).Reviewed by Cursor Bugbot for commit 5cdc29e. Bugbot is set up for automated code reviews on this repo. Configure here.